Modify defensive programming section #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/python-intermediate-development/compare/md-outputs..md-outputs-PR-451 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-04-17 14:53:11 +0000 |
* Remove explicit use of np.assert_allclose under pytest.raises * Add Exception message matching to optional exercise
bielsnohr
force-pushed
the
bielsnohr/108-check-error-raised
branch
from
ddfba29 to
3b41928
Compare
anenadic
approved these changes
May 27, 2025
Collaborator
anenadic
left a comment
anenadic
left a comment
There was a problem hiding this comment.
Looks good to me - thank you @bielsnohr.
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
Auto-generated via `{sandpaper}`
Source : 1d26a2d
Branch : main
Author : Aleksandra Nenadic <[email protected]>
Time : 2025-05-27 09:38:06 +0000
Message : Merge pull request #451 from carpentries-incubator/bielsnohr/108-check-error-raised
Modify defensive programming section
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
Auto-generated via `{sandpaper}`
Source : 6ca5325
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-05-27 09:38:59 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 1d26a2d
Branch : main
Author : Aleksandra Nenadic <[email protected]>
Time : 2025-05-27 09:38:06 +0000
Message : Merge pull request #451 from carpentries-incubator/bielsnohr/108-check-error-raised
Modify defensive programming section
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
Auto-generated via `{sandpaper}`
Source : 6ca5325
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-05-27 09:38:59 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 1d26a2d
Branch : main
Author : Aleksandra Nenadic <[email protected]>
Time : 2025-05-27 09:38:06 +0000
Message : Merge pull request #451 from carpentries-incubator/bielsnohr/108-check-error-raised
Modify defensive programming section
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
Auto-generated via `{sandpaper}`
Source : 6ca5325
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-05-27 09:38:59 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 1d26a2d
Branch : main
Author : Aleksandra Nenadic <[email protected]>
Time : 2025-05-27 09:38:06 +0000
Message : Merge pull request #451 from carpentries-incubator/bielsnohr/108-check-error-raised
Modify defensive programming section
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
Auto-generated via `{sandpaper}`
Source : 6ca5325
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-05-27 09:38:59 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 1d26a2d
Branch : main
Author : Aleksandra Nenadic <[email protected]>
Time : 2025-05-27 09:38:06 +0000
Message : Merge pull request #451 from carpentries-incubator/bielsnohr/108-check-error-raised
Modify defensive programming section
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
Auto-generated via `{sandpaper}`
Source : 6ca5325
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-05-27 09:38:59 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 1d26a2d
Branch : main
Author : Aleksandra Nenadic <[email protected]>
Time : 2025-05-27 09:38:06 +0000
Message : Merge pull request #451 from carpentries-incubator/bielsnohr/108-check-error-raised
Modify defensive programming section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crucial note: I have not tested this with the project repo code. Not sure when I will get time to do that, but if someone else does have an hour or so to spare, please feel free to verify that the code edits below work.
Closes #108